Re: [PATCH 2/2] perf/x86/intel/uncore: Add Knights Landing uncore PMU support

[Harish Chegondi]

On 12/09/2015 03:37 PM, Peter Zijlstra wrote:
> On Wed, Dec 09, 2015 at 01:03:43PM -0800, Harish Chegondi wrote:
>>
>> On 12/08/2015 01:07 AM, Peter Zijlstra wrote:
>>> On Mon, Dec 07, 2015 at 02:32:32PM -0800, Harish Chegondi wrote:
>>>> @@ -981,6 +990,8 @@ static int __init uncore_pci_init(void)
>>>>  		break;
>>>>  	case 61: /* Broadwell */
>>>>  		ret = bdw_uncore_pci_init();
>>>> +	case 87: /* Knights Landing */
>>>> +		ret = knl_uncore_pci_init();
>>>>  		break;
>>>>  	default:
>>>>  		return 0;
>>>> @@ -1289,6 +1300,8 @@ static int __init uncore_cpu_init(void)
>>>>  		break;
>>>>  	case 86: /* BDX-DE */
>>>>  		bdx_uncore_cpu_init();
>>>> +	case 87: /* Knights Landing */
>>>> +		knl_uncore_cpu_init();
>>>>  		break;
>>>>  	default:
>>> Surely you need some extra break statements in there?
>>> .
>>>
>> Yes, I missed the break statements. I will add the breaks in the next version of the patch.
> Fixed it already. No need to resend.
> .
>
Thank you very much!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/