Re: [PATCH v2 4/9] pinctrl: Add support STM32 MCUs

[Linus Walleij]

On Tue, Dec 1, 2015 at 10:53 AM, Maxime Coquelin
<mcoquelin.stm32@xxxxxxxxx> wrote:
> 2015-10-17 19:23 GMT+02:00 Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>:
>> This patch adds pinctrl and GPIO support to STMicroelectronic's STM32
>> family of MCUs.
>>
>> While it only supports STM32F429 for now, it has been designed to enable
>> support of other MCUs of the family (e.g. STM32F746).
>>
>> Signed-off-by: Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>
>> ---
>>  drivers/pinctrl/Kconfig                   |    1 +
>>  drivers/pinctrl/Makefile                  |    1 +
>>  drivers/pinctrl/stm32/Kconfig             |   16 +
>>  drivers/pinctrl/stm32/Makefile            |    5 +
>>  drivers/pinctrl/stm32/pinctrl-stm32.c     |  856 +++++++++++++++
>>  drivers/pinctrl/stm32/pinctrl-stm32.h     |   43 +
>>  drivers/pinctrl/stm32/pinctrl-stm32f429.c | 1598 +++++++++++++++++++++++++++++
>>  7 files changed, 2520 insertions(+)
>>  create mode 100644 drivers/pinctrl/stm32/Kconfig
>>  create mode 100644 drivers/pinctrl/stm32/Makefile
>>  create mode 100644 drivers/pinctrl/stm32/pinctrl-stm32.c
>>  create mode 100644 drivers/pinctrl/stm32/pinctrl-stm32.h
>>  create mode 100644 drivers/pinctrl/stm32/pinctrl-stm32f429.c
>>
>
> Gentle reminder, do you know when you will be able to review this driver?

I'm a bit overloaded so reviewing of large chunks of code takes time.

It would be great if I could have some Reviewed-by tags from someone
else who's familiar with pin control.

Patrice: do you have a chance to review this driver and help us?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/