Re: [PATCH/RFC 01/16] perf top: Delete half-processed hist entries when exit

From: Arnaldo Carvalho de Melo
Date: Thu Dec 10 2015 - 13:57:56 EST


Em Thu, Dec 10, 2015 at 09:55:44AM +0000, åæéå / HIRAMATUïMASAMI escreveu:
> >From: Namhyung Kim [mailto:namhyung@xxxxxxxxxx]
> >
> >After sample processing is done, hist entries are in both of
> >hists->entries and hists->entries_in (or hists->entries_collapsed).
> >So I guess perf report does not have leaks on hists.
> >
> >But for perf top, it's possible to have half-processed entries which
> >are only in hists->entries_in. Eventually they will go to the
> >hists->entries and get freed but they cannot be deleted by current
> >hists__delete_entries(). This patch adds hists__delete_all_entries
> >function to delete those entries.
> >
>
> This is tested under the refcnt debugger and I've reviewed it.
>
> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>
> Tested-by: Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>

Thanks, applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/