Re: [PATCH linux-next] mtd: part: Add BCM962368 CFE partitioning support

[Simon Arlott]

On 10/12/15 17:41, Florian Fainelli wrote:
> Le 09/12/2015 13:55, Simon Arlott a Ãcrit :
>>  drivers/mtd/Kconfig         |  21 +++
>>  drivers/mtd/Makefile        |   1 +
>>  drivers/mtd/bcm963268part.c | 373 ++++++++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 395 insertions(+)
>>  create mode 100644 drivers/mtd/bcm963268part.c
> 
> What motivated created a separate partition parser rather then using the
> extended the existing one?

I started off doing that but had to split it up because how it handles
the nvram and bcm_tag to construct the partition layout is significantly
different. The nvram isn't even read from flash in bcm63xxpart, and the
psi size value isn't used by bcm963268.

> I would imagine that, at some point, the partition parser could know
> what kind of flash it needs to parse: SPI/P-NOR or NAND, and based on
> that, do an appropriate definition?

With the device tree changes Brian's introducing it can be specified in
there, otherwise a common parser would need to read from the
miscStrapBus register which would be difficult for a partition parser as
it's not a device and has no memory resources.

-- 
Simon Arlott
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/