Re: [PATCH 1/4] usb: serial: remove redundant conditions

From: Geyslan G. Bem
Date: Fri Dec 11 2015 - 04:35:48 EST


2015-12-11 6:16 GMT-03:00 Johan Hovold <johan@xxxxxxxxxx>:
> On Thu, Dec 10, 2015 at 05:50:09PM -0300, Geyslan G. Bem wrote:
>> This patch removes redundant conditions.
>>
>> (!A || (A && B)) is the same as (!A || B).
>> (length && length > 5) can be reduced to a single evaluation.
>>
>> Tested by compilation only.
>> Caught by cppcheck.
>>
>> Signed-off-by: Geyslan G. Bem <geyslan@xxxxxxxxx>
>> ---
>> drivers/usb/serial/io_edgeport.c | 35 ++++++++++++++---------------------
>> drivers/usb/serial/mos7840.c | 2 +-
>> 2 files changed, 15 insertions(+), 22 deletions(-)
>
> Please split this up per driver as I (and Felipe) asked.
Sorry. get_maintainer give same maintainers, but the question here is
the different drivers. Ok, I'll send them splitted.

>
> You can send these two separate from the rest, and remember to CC
> the USB list.
Ok, tks.

>
> Thanks,
> Johan



--
Regards,

Geyslan G. Bem
hackingbits.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/