Re: [PATCH 0/2] staging: COMEDI: checkpatch.pl cleanups in comedi.h

From: Ian Abbott
Date: Fri Dec 11 2015 - 05:01:36 EST


On 10/12/15 14:57, Moritz KÃnig wrote:
This patchset fixes all the warnings and legitimate checks of
checkpatch.pl in comedi.h.

The following warnings were fixed:
* WARNING: Block comments use * on subsequent lines
* WARNING: Block comments use a trailing */ on a separate line
The following checks were fixed:
* CHECK: spaces preferred around that '<<' (ctx:VxV)
* CHECK: spaces preferred around that '>>' (ctx:VxV)
* CHECK: spaces preferred around that '|' (ctx:VxV)

The following checks are not legitimate here and were not fixed:
* CHECK: spaces preferred around that '&' (ctx:VxV)
This '&' is not a binary operator, but a referencing.
* CHECK: Prefer using the BIT macro
The author defined a BIT macro here.
* CHECK: Avoid CamelCase: <UNIT_mA>
This refers to the unit 'milli ampere'.

Moritz KÃnig (2):
staging: COMEDI: Fixed the format of comments
staging: COMEDI: Added missing spaces at binary operators

drivers/staging/comedi/comedi.h | 232 +++++++++++++++++++++++-----------------
1 file changed, 131 insertions(+), 101 deletions(-)


Thanks. There's an outstanding patch by Daniel H. Hemmingsen that also fixes these issues:

http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-November/081778.html

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Web: http://www.mev.co.uk/ )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/