Re: [PATCH] devpts: Sensible /dev/ptmx & force newinstance

[Al Viro]

On Fri, Dec 11, 2015 at 01:40:40PM -0600, Eric W. Biederman wrote:

> +	inode = path.dentry->d_inode;
> +	filp->f_path = path;
> +	filp->f_inode = inode;
> +	filp->f_mapping = inode->i_mapping;
> +	path_put(&old);

Don't.  You are creating a fairly subtle constraint on what the code in
fs/open.c and fs/namei.c can do, for no good reason.  You can bloody
well maintain the information you need without that.

I'm less than thrilled about the whole approach as it is, but this definitely
pushes it into the NAK-on-sight territory.  We'd been through that 3 years
ago when you brought that kind of hacks up last time; the objections still
stand.

Don't make it any more of a special snowflake than it absolutely has to be.
We already have more than enough potential headache sources to keep track
of when doing any kind of work on core kernel and extra ones are not
appreciated.  Really.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/