Re: [PATCHv5 7/7] pciutils: Allow 32-bit domains

[Andy Shevchenko]

On Mon, Dec 7, 2015 at 11:32 PM, Keith Busch <keith.busch@xxxxxxxxx> wrote:
> PCI-e segments will continue to use the lower 16 bits as required by
> ACPI. Special domains may use the full 32-bits.
>
> Signed-off-by: Keith Busch <keith.busch@xxxxxxxxx>
> ---
>  lib/filter.c |    2 +-
>  lib/pci.h    |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/filter.c b/lib/filter.c
> index d4254a0..075dc2f 100644
> --- a/lib/filter.c
> +++ b/lib/filter.c
> @@ -45,7 +45,7 @@ pci_filter_parse_slot_v33(struct pci_filter *f, char *str)
>           if (str[0] && strcmp(str, "*"))
>             {
>               long int x = strtol(str, &e, 16);
> -             if ((e && *e) || (x < 0 || x > 0xffff))
> +             if ((e && *e) || (x < 0))
>                 return "Invalid domain number";
>               f->domain = x;
>             }
> diff --git a/lib/pci.h b/lib/pci.h
> index 10ba831..7e42765 100644
> --- a/lib/pci.h
> +++ b/lib/pci.h
> @@ -119,7 +119,7 @@ struct pci_param *pci_walk_params(struct pci_access *acc, struct pci_param *prev
>
>  struct pci_dev {
>    struct pci_dev *next;                        /* Next device in the chain */
> -  u16 domain;                          /* PCI domain (host bridge) */

> +  int32_t domain;                      /* PCI domain (host bridge) */

Why not u32 ?

>    u8 bus, dev, func;                   /* Bus inside domain, device and function */
>
>    /* These fields are set by pci_fill_info() */
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/