Re: [PATCH] staging: speakup: kobjects.c: fix char argument to %02x

[Andy Shevchenko]

On Sun, Dec 6, 2015 at 2:05 AM, Rasmus Villemoes
<linux@xxxxxxxxxxxxxxxxxx> wrote:
> If char is signed and ch happens to be negative, printing ch with
> "%02x" will not do as intended (when ch is -19, one will get
> "ffffffed"). Fix that by masking with 0xff.
>
> Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>
> ---
>  drivers/staging/speakup/kobjects.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c
> index fdfeb42b2b8f..8b88f03e266b 100644
> --- a/drivers/staging/speakup/kobjects.c
> +++ b/drivers/staging/speakup/kobjects.c
> @@ -567,7 +567,7 @@ ssize_t spk_var_show(struct kobject *kobj, struct kobj_attribute *attr,
>                                 if (ch >= ' ' && ch < '~')
>                                         *cp1++ = ch;
>                                 else
> -                                       cp1 += sprintf(cp1, "\\x%02x", ch);
> +                                       cp1 += sprintf(cp1, "\\x%02x", ch & 0xff);

Have you considered to use string_escape_str()?


This one clearly looks like ESCAPE_HEX.

>                         }
>                         *cp1++ = '"';
>                         *cp1++ = '\n';
> --
> 2.6.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/



-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/