RE: [PATCH v2] I2C: designware: fix IO timeout issue for AMD controller

[Yu, Xiangliang]

> -----Original Message-----
> From: Wolfram Sang [mailto:wsa@xxxxxxxxxxxxx]
> Sent: Sunday, December 13, 2015 1:03 AM
> To: Yu, Xiangliang
> Cc: andriy.shevchenko@xxxxxxxxxxxxxxx; jarkko.nikula@xxxxxxxxxxxxxxx;
> mika.westerberg@xxxxxxxxxxxxxxx; linux-i2c@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; SPG_Linux_Kernel
> Subject: Re: [PATCH v2] I2C: designware: fix IO timeout issue for AMD
> controller
> 
> On Fri, Dec 11, 2015 at 08:02:53PM +0800, Xiangliang Yu wrote:
> > Because of some hardware limitation, AMD I2C controller can't trigger
> > pending interrupt if interrupt status has been changed after clearing
> > interrupt status bits. Then, I2C will lost interrupt and IO timeout.
> >
> > According to hardware design, this patch implements a workaround to
> > disable i2c controller interrupt and re-enable i2c interrupt before
> > exiting ISR.
> >
> > To reduce the performance impacts on other vendors, use unlikely
> > function to check flag in ISR.
> > ---
> 
> Don't manually add "---". This breaks a lot of workflow scripts.
> "Patchwork" missed your Signed-off, for example!
Sorry for my mistake. 

> > Changes in v2:
> >     - pass flags with ->driver_data
> >     - unmask interrupt right after masking
> 
> This paragraph...
>
> >
> > Signed-off-by: Xiangliang Yu <Xiangliang.Yu@xxxxxxx>
> > ---
> 
> ... needs to go here.
> 
> However, I fixed it this time and applied to for-current, thanks!

Thank you very much!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/