Re: [PATCH 0/9] Fix checkpatch errors

From: Nicolai Stange
Date: Sun Dec 13 2015 - 13:15:24 EST


Frederik <frederik.voelkel@xxxxxx> writes:

> On Sat, 12. Dec 23:06, Greg KH wrote:
>> On Fri, Dec 11, 2015 at 11:36:00AM +0100, Frederik VÃlkel wrote:
>> > This patch series fixes all checkpatch error in 68328serial.c except
>> > 5 trailing whitespace errors we are unsure how to fix.
>>
>> What are the errors you are not sure how to fix?
>>
>> thanks,
>>
>> greg k-h
>
> All 5 errors are at comments. It is not clear to us where exactly the
> trailing whitespace is checkpatch complains(lines 271, 770, 889, 993
> and 1040).

W/o your series applied (so line numbering might be slightly
different), checkpatch.pl says:

ERROR: trailing whitespace
#270: FILE: -:270:
+^I * This do { } while() loop will get ALL chars out of Rx FIFO $

AFAICS, your patch [7/9] ("drivers: tty: 68328serial.c: remove trailing
whitespaces") doesn't fix this one.

In good old regexp tradition, the '$' sign denotes the end of line. So,
there is a single space after "FIFO" and before the end of line.

If you happen to be Emacs users, consider trying out whitespace-mode.
If not, try to find another way to make your editor visualize whitespace
somehow.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/