Re: [PATCH 3.16.y-ckt 009/126] sit: fix sit0 percpu double allocations

[Ben Hutchings]

On Sun, 2015-12-13 at 13:44 -0800, Eric Dumazet wrote:
> On Sun, 2015-12-13 at 21:22 +0000, Ben Hutchings wrote:
> > On Sun, 2015-12-13 at 12:43 -0800, Eric Dumazet wrote:
> 
> > > 1) Sorry Ben, I do not understand the problem you mention.
> > > ÂÂÂWhat is a partially initialized device exactly ?
> > 
> > A tunnel device which is registered but hasn't had its private
> > structure fully initialised yet.
> 
> And you see this happening after my patch ? I am blind.
> 
> I am referring to current linux kernel, not to a backport to pre 3.18
> kernels, that was not considered when I wrote this patch.
> 
> By the time ipip6_fb_tunnel_init() is called, dev->tstats had been
> already allocated in ipip6_tunnel_init(), so what is missing ?

You moved this initialisation below the registration:

> 	ipip6_tunnel_clone_6rd(sitn->fb_tunnel_dev, sitn);
> 	ipip6_fb_tunnel_init(sitn->fb_tunnel_dev);

Ben.

-- 
Ben Hutchings
Life would be so much easier if we could look at the source code.

Attachment: signature.asc
Description: This is a digitally signed message part