Re: [PATCH 02/10] fs: make quota/netlink.c explicitly non-modular

From: Jan Kara
Date: Mon Dec 14 2015 - 06:04:07 EST


On Sat 12-12-15 16:30:04, Paul Gortmaker wrote:
> The Kconfig currently controlling compilation of this code is:
>
> config QUOTA_NETLINK_INTERFACE
> bool "Report quota messages through netlink interface"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the couple traces of modularity so that when reading the
> driver there is no doubt it is builtin-only.
>
> Since module_init translates to device_initcall in the non-modular
> case, the init ordering gets bumped to one level earlier when we
> use the more appropriate fs_initcall here. However we've made similar
> changes before without any fallout and none is expected here either.
>
> Cc: Jan Kara <jack@xxxxxxxx>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>

Looks good. I have taken the patch into my tree.

Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/