Re: [PATCH v3 15/17] perf: Finalize subcmd independence

[Josh Poimboeuf]

On Mon, Dec 14, 2015 at 11:32:20AM +0100, Jiri Olsa wrote:
> On Sun, Dec 13, 2015 at 10:18:15PM -0600, Josh Poimboeuf wrote:
> > For the files that will be moved to the subcmd library, remove all their
> > perf-specific includes and duplicate any needed functionality.
> > 
> > Signed-off-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> > ---
> >  tools/perf/util/exec_cmd.c      | 75 +++++++++++++++++++++++++++++++++++++----
> >  tools/perf/util/help.c          | 47 +++++++++++++++++++++++---
> >  tools/perf/util/help.h          |  4 ++-
> >  tools/perf/util/pager.c         |  7 +++-
> >  tools/perf/util/parse-options.c | 68 +++++++++++++++++++++++--------------
> >  tools/perf/util/parse-options.h |  2 +-
> >  tools/perf/util/run-command.c   | 16 ++++++---
> >  tools/perf/util/run-command.h   |  2 ++
> >  tools/perf/util/sigchain.c      |  3 +-
> >  tools/perf/util/subcmd-util.h   | 67 ++++++++++++++++++++++++++++++++++++
> >  tools/perf/util/util.h          | 14 --------
> >  11 files changed, 247 insertions(+), 58 deletions(-)
> 
> this duplicates functions that we have already in perf,
> I think we better move them into lib first..
>   strlcpy, die, xrealloc, ALLOC_GROW
> 
> and probably some others...

The duplication was an intentional decision we made in the v2 discussion
in order to keep the library's scope focused on 'subcmd'.

-- 
Josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/