Re: Commit 81a43adae3b9 (locking/mutex: Use acquire/release semantics) causing failures on arm64 (ThunderX)

From: Peter Zijlstra
Date: Mon Dec 14 2015 - 15:32:15 EST


On Mon, Dec 14, 2015 at 06:49:31PM +0000, One Thousand Gnomes wrote:
>
> But seriously are there any cases we actually care about this for osq ?

So I think what PaulMck is worried about is that one would expect things
like:

mutex_lock();
MMIO(++var);
mutex_unlock();

(the same example Linus gave but with a mutex instead of a spinlock) to
just work.

Now, I haven't checked the code, but I'm not sure we ever rely on osq to
provide the mutex ACQUIRE barrier, since we always need to acquire the
mutex variable itself after we've acquired the osq 'lock'.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/