Re: [POWERPC] bootwrapper: One check less in fsl_get_immr() after error detection

From: Scott Wood
Date: Mon Dec 14 2015 - 17:34:37 EST


On Mon, 2015-12-14 at 23:10 +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Mon, 14 Dec 2015 23:01:32 +0100
>
> A status check was performed by the fsl_get_immr() function even if it
> was known already that a system setting did not fit to the expectations.
>
> This implementation detail could be improved by an adjustment for
> a jump label according to the Linux coding style convention.

What is the actual problem you're trying to solve? Cluttering the code to
micro-optimize an error path is not an improvement.

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/