Re: [PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert_port

[Or Gerlitz]

On 12/14/2015 12:05 PM, Andrzej Hajda wrote:
> The function can return negative values, so its result should
> be assigned to signed variable.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/assign_signed_to_unsigned.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2046107

Please add here

Fixes: fc48866f7 ('net/mlx4: Adapt code for N-Port VF')


> Signed-off-by: Andrzej Hajda <a.hajda@xxxxxxxxxxx>

otherwise, Looks good

Acked-by: Or Gerlitz <ogerlitz@xxxxxxxxxxxx>

Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/