Re: [PATCH 6/6] perf tools: Try to show pretty printed output for dynamic sort keys

[Namhyung Kim]

On Tue, Dec 15, 2015 at 07:36:37AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Dec 15, 2015 at 10:03:29AM +0100, Jiri Olsa escreveu:
> > On Tue, Dec 15, 2015 at 12:46:13AM +0900, Namhyung Kim wrote:
> > > Each tracepoint event has format string for print to improve
> > > readability.  Try to parse the output and match the field name.  If it
> > > finds one, use that for the result.  If not, fallbacks to the original
> > > output.
> > > 
> > > For example, sort on kmem:kmalloc.gfp_flags looks like below:
> > > (Note: libtraceevent plugins are not installed on my system.  They might
> > > affect the output below)
> > > 
> > > Before:
> > >   # Overhead  Command   gfp_flags
> > >   # ........  .......  ..........
> > >   #
> > >       99.89%  perf          32848
> > >        0.06%  sleep           208
> > >        0.03%  perf          32976
> > >        0.01%  perf            208
> > > 
> > > After:
> > >   # Overhead  Command            gfp_flags
> > >   # ........  .......  ...................
> > >   #
> > >       99.89%  perf       GFP_NOFS|GFP_ZERO
> > >        0.06%  sleep             GFP_KERNEL
> > >        0.03%  perf     GFP_KERNEL|GFP_ZERO
> > >        0.01%  perf              GFP_KERNEL
> > 
> > hum, maybe we want some way to switch back to numbers?

OK.  Maybe something like 'kmem:kmalloc.gfp_flags/raw' ?


> 
> Or remove repetitive stuff like GFP_? I guess this was done already for
> perf kmem?

Right, perf-kmem did that.  But perf-report is more general and it's
hard to handle every field this way.  Also I think it might be better
to keep the output as perf-script.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/