[PATCH] Drivers: hv: utils: fix hvt_op_poll() return value on transport destroy

From: Vitaly Kuznetsov
Date: Tue Dec 15 2015 - 12:37:43 EST


The return type of hvt_op_poll() is unsigned int and -EBADF is
inappropriate, poll functions return POLL* statuses.

Reported-by: Dexuan Cui <decui@xxxxxxxxxxxxx>
Signed-off-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>
---
- This is a follow-up to the previously sent 'Drivers: hv: utils: introduce
HVUTIL_TRANSPORT_DESTROY mode' patch which is already in
char-misc-testing tree (a15025660d47).
---
drivers/hv/hv_utils_transport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hv/hv_utils_transport.c b/drivers/hv/hv_utils_transport.c
index ee20b50..4f42c0e 100644
--- a/drivers/hv/hv_utils_transport.c
+++ b/drivers/hv/hv_utils_transport.c
@@ -109,7 +109,7 @@ static unsigned int hvt_op_poll(struct file *file, poll_table *wait)
poll_wait(file, &hvt->outmsg_q, wait);

if (hvt->mode == HVUTIL_TRANSPORT_DESTROY)
- return -EBADF;
+ return POLLERR | POLLHUP;

if (hvt->outmsg_len > 0)
return POLLIN | POLLRDNORM;
--
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/