Re: 4.4-rc5: ugly warn on: 5 W+X pages found

[Linus Torvalds]

On Tue, Dec 15, 2015 at 10:30 AM, Borislav Petkov <bp@xxxxxxxxx> wrote:
> On Tue, Dec 15, 2015 at 09:45:40AM -0800, Linus Torvalds wrote:
>>
>>   +static inline int kernel_write_execute_prot(pgprotval_t protval)
>>   +{
>>   +       return !(protval & _PAGE_USER) &&
>>   +               !(protval & _PAGE_NX) &&
>
> Shouldn't this be without a "!"? AFAIU, we want _PAGE_NX | _PAGE_RW?

We want to *warn* about PAGE_RW without PAGE_NX.  No?

                 Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/