Re: [PATCH] i2c: designware: Add support for AMD Seattle I2C

[Suravee Suthikulpanit]

On 12/16/2015 03:16 AM, Mika Westerberg wrote:
> On Tue, Dec 15, 2015 at 08:14:34PM -0600, Suravee Suthikulpanit wrote:
> > Hi Mika,
> >
> > On 12/15/15 15:55, Suravee Suthikulpanit wrote:
> > > Add device HID AMDI0510 to match the I2C controlers on AMD Seattle platform
> > >
> > > Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@xxxxxxx>
> > > ---
> > >   drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
> > >   1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> > > index 57f623b..a027154 100644
> > > --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> > > +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> > > @@ -117,6 +117,7 @@ static const struct acpi_device_id dw_i2c_acpi_match[] = {
> > >   	{ "80860F41", 0 },
> > >   	{ "808622C1", 0 },
> > >   	{ "AMD0010", 0 },
> > > +	{ "AMDI0510", 0 },
> > >   	{ }
> >
> > Since this driver seems to be used by several SOCs, and we have been adding
> > the HID from various SOC vendors. Do you think it would be better to assign
> > a CID so that each SOC vendor can specify in their ACPI DSDT and we can
> > match them here?
>
> Sure _CID would work here.

Do you know if Synopsys has already provided a CID that we can use for 
this? If not, who do you think should provide this?  Also, do you think 
the FMCN and SSCN should be documented somewhere in the spec so that FW 
and OSes can agree upon going forward?

> > Then, we can also associate the FMCN and SSCN along with the CID, and
> > guarantee compatibility.
>
> Well, the driver checks those everytime it finds that the device has
> ACPI companion regardless of _HID/_CID.

Not sure what you mean by "device has ACPI companion". Do you mean the 
driver check those for every matched devices here?

Thanks,
Suravee

> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/