[PATCH v2 1/2] drm/vc4: make function as void

From: Sudip Mukherjee
Date: Thu Dec 17 2015 - 05:39:41 EST


The return value of vc4_v3d_set_power() is never checked, we can make it
void.

Signed-off-by: Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>
---
drivers/gpu/drm/vc4/vc4_drv.h | 2 +-
drivers/gpu/drm/vc4/vc4_v3d.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h
index 080865e..47b9fc9 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.h
+++ b/drivers/gpu/drm/vc4/vc4_drv.h
@@ -434,7 +434,7 @@ void vc4_plane_async_set_fb(struct drm_plane *plane,
extern struct platform_driver vc4_v3d_driver;
int vc4_v3d_debugfs_ident(struct seq_file *m, void *unused);
int vc4_v3d_debugfs_regs(struct seq_file *m, void *unused);
-int vc4_v3d_set_power(struct vc4_dev *vc4, bool on);
+void vc4_v3d_set_power(struct vc4_dev *vc4, bool on);

/* vc4_validate.c */
int
diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c
index 424d515..fc81412 100644
--- a/drivers/gpu/drm/vc4/vc4_v3d.c
+++ b/drivers/gpu/drm/vc4/vc4_v3d.c
@@ -150,13 +150,13 @@ int vc4_v3d_debugfs_ident(struct seq_file *m, void *unused)
* This may be doable with just the clocks interface, though this
* packet does some other register setup from the firmware, too.
*/
-int
+void
vc4_v3d_set_power(struct vc4_dev *vc4, bool on)
{
if (on)
- return pm_generic_poweroff(&vc4->v3d->pdev->dev);
+ pm_generic_poweroff(&vc4->v3d->pdev->dev);
else
- return pm_generic_resume(&vc4->v3d->pdev->dev);
+ pm_generic_resume(&vc4->v3d->pdev->dev);
}

static void vc4_v3d_init_hw(struct drm_device *dev)
--
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/