Re: [PATCH V2 02/10] irqchip / GICv3: Add ACPI support for GICv3+ initialization

From: Tomasz Nowicki
Date: Thu Dec 17 2015 - 10:14:33 EST


On 17.12.2015 14:44, kbuild test robot wrote:
Hi Tomasz,

[auto build test ERROR on v4.4-rc4]
[also build test ERROR on next-20151217]
[cannot apply to tip/irq/core v4.4-rc5]

url: https://github.com/0day-ci/linux/commits/Tomasz-Nowicki/Introduce-ACPI-world-to-GICv3-ITS-irqchip/20151217-195910
config: arm-allyesconfig (attached as .config)
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm

All errors (new ones prefixed by >>):

drivers/irqchip/irq-gic-v3.c: In function 'gic_irq_domain_translate':
drivers/irqchip/irq-gic-v3.c:768:2: error: implicit declaration of function 'is_fwnode_irqchip' [-Werror=implicit-function-declaration]
if (is_fwnode_irqchip(fwspec->fwnode)) {
^
cc1: some warnings being treated as errors

vim +/is_fwnode_irqchip +768 drivers/irqchip/irq-gic-v3.c

762 }
763
764 *type = fwspec->param[2] & IRQ_TYPE_SENSE_MASK;
765 return 0;
766 }
767
> 768 if (is_fwnode_irqchip(fwspec->fwnode)) {
769 if(fwspec->param_count != 2)
770 return -EINVAL;
771


It is because I missed irqdomain.h header for irq-gic-v3.c and irq-gic-v3-its.c files. Fixed in version 3.

Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/