Re: [PATCH] i2c: allow building emev2 without slave mode again
From: Wolfram Sang
Date: Thu Dec 17 2015 - 14:40:29 EST
> > My conclusion for now is:
> >
> > There needs something to be done surely, but currently I don't have the
> > bandwidth to do it or even play around with it. I am not fully happy
> > with your patches as well because __maybe_unused has some kind of "last
> > resort" feeling to me.
>
> I generally like __maybe_unused, but it's a matter of personal preference.
> We could avoid the __maybe_unused if the reg_slave/unreg_slave callback
> pointers are always available in struct i2c_algorithm.
Yes, I was thinking in this direction, looking at how PM does it. Needs
some playing around, though.
> Just for reference, see below for my combined patch, in case you decide
> to use that at a later point.
Thanks a lot!
Attachment:
signature.asc
Description: Digital signature