Re: [lm-sensors] LM90 driver and ti tmp461 detection

From: Andreas Werner
Date: Fri Dec 18 2015 - 03:20:06 EST


On Thu, Dec 17, 2015 at 06:57:51AM -0800, Guenter Roeck wrote:
> On Thu, Dec 17, 2015 at 12:48:08PM +0100, Jean Delvare wrote:
> > Hi Andreas,
> >
> > On Tue, 15 Dec 2015 16:11:24 +0100, Andreas Werner wrote:
> > > here is the register dump of the tmp461.
> >
> > Thanks.
> >
> > > It seemse that we really cannot detect if it is a tmp461 or a tmp451.
> > > Also the magic "ID Register" offset 0xff is 0x00 for both devices.
> >
> > I would use register 0x16, which doesn't exist but reads 0x00 on the
> > TMP451. It could in theory also read 0x00 on the TMP461 but only if
> > both channels are disabled, which makes little sense. More likely at
> > least one channel will be enabled so you'll have value 0x01-0x03 if
> > this is a TMP461.
> >
> Excellent idea!
>
> Guenter

Ok, i will implement the detection for the tm461 and also the temp calculation
for setting the temperature value.

Will send a patch as soon as i am done.

Regards
Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/