Re: [RFC PATCH V2 8/8] irqchip/gic: Add support for tegra AGIC interrupt controller

From: Jon Hunter
Date: Fri Dec 18 2015 - 05:44:38 EST



On 17/12/15 13:32, Linus Walleij wrote:
> On Thu, Dec 17, 2015 at 11:48 AM, Jon Hunter <jonathanh@xxxxxxxxxx> wrote:
>
>> Add a driver for the Tegra-AGIC interrupt controller which is compatible
>> with the ARM GIC-400 interrupt controller.
> (...)
>> +static const struct dev_pm_ops gic_pm_ops = {
>> + SET_RUNTIME_PM_OPS(gic_runtime_suspend,
>> + gic_runtime_resume, NULL)
>> + SET_SYSTEM_SLEEP_PM_OPS(gic_suspend, gic_resume)
>> +};
>
> Now you do what I commented on in the earlier patch: assign
> the runtime PM functions to normal suspend/resume.
>
> This will have the effect of inhibiting any IRQs marked for
> wakeup on the GIC, even if you just want to go to sleep until
> something happens, will it not?
>
> You should turn on the alarm clock before going to bed, not
> turn it off, as figure of speak ...

Yes I am alway having problems with my alarm, may be this is why ;-)

I see what you are saying, so if there are any wake-ups enabled then we
should not suspend the chip. Right?

Cheers
Jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/