Re: [PATCH 13/43] MAINTAINERS: fix git URL for EDAC

[Borislav Petkov]

On Fri, Dec 18, 2015 at 06:57:33PM +0800, Fengguang Wu wrote:
> That's the required format, documented earlier in MAINTAINERS:
> 
>         T: SCM tree type and location.
>            Type is one of: git, hg, quilt, stgit, topgit
> 
> Which is followed all other places, eg.
> 
> T:      git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
> T:      git https://github.com/Xilinx/linux-xlnx.git

Right, and IMO it should be done something like the diff below.

The T: should contain the URL and if it is not clear from the URL
type, the *type* of the repository should be appended and not some
commands like "hg" or "quilt" or whatever. Especially if those commands
don't necessarily tell you what the repo is unless you know what the
executables' names mean.

---
diff --git a/MAINTAINERS b/MAINTAINERS
index 7271b6189ccf..09a9c76ff83e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -75,8 +75,8 @@ Descriptions of section entries:
 	L: Mailing list that is relevant to this area
 	W: Web-page with status/info
 	Q: Patchwork web based patch tracking system site
-	T: SCM tree type and location.
-	   Type is one of: git, hg, quilt, stgit, topgit
+	T: SCM tree type and location. If it is not clear from the SCM URL, the
+	   SCM type is appended in brackets.
 	S: Status, one of the following:
 	   Supported:	Someone is actually paid to look after this.
 	   Maintained:	Someone actually looks after it.
@@ -1739,7 +1739,7 @@ M:	Michal Simek <michal.simek@xxxxxxxxxx>
 R:	SÃren Brinkmann <soren.brinkmann@xxxxxxxxxx>
 L:	linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated for non-subscribers)
 W:	http://wiki.xilinx.com
-T:	git https://github.com/Xilinx/linux-xlnx.git
+T:	https://github.com/Xilinx/linux-xlnx.git (git)
 S:	Supported
 F:	arch/arm/mach-zynq/
 F:	drivers/cpuidle/cpuidle-zynq.c
@@ -5604,7 +5604,7 @@ M:	Gang Wei <gang.wei@xxxxxxxxx>
 M:	Shane Wang <shane.wang@xxxxxxxxx>
 L:	tboot-devel@xxxxxxxxxxxxxxxxxxxxx
 W:	http://tboot.sourceforge.net
-T:	hg http://tboot.hg.sourceforge.net:8000/hgroot/tboot/tboot
+T:	http://tboot.hg.sourceforge.net:8000/hgroot/tboot/tboot (mercurial)
 S:	Supported
 F:	Documentation/intel_txt.txt
 F:	include/linux/tboot.h

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/