Re: [PATCH v2] mtd: spi-nor: fsl-quadspi: add big-endian support

From: Brian Norris
Date: Fri Dec 18 2015 - 17:55:39 EST


On Fri, Dec 18, 2015 at 09:12:13AM +0000, Yao Yuan wrote:
> Hi Woodhouse, Norris,
>
> Do you have any comments for this patch?

No, it looks fine. But the driver maintainer (Han) already asked you for
DT binding documentation already. This is a requirement before I can
merge your patch. See
Documentation/devicetree/bindings/submitting-patches.txt.

> Thanks for your review.
>
> Best Regards,
> Yuan Yao
>
> > -----Original Message-----
> > From: Han Xu [mailto:han.xu@xxxxxxxxxxxxx]

> > > + q->big_endian = of_property_read_bool(np, "big-endian");
> >
> > I am fine with this patch, but need document the new property with another
> > patch

^^^ See here

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/