RE: [PATCH v4 05/19] irqchip: add nps Internal and external irqchips

From: Noam Camus
Date: Sat Dec 19 2015 - 04:31:29 EST


>From: Marc Zyngier [mailto:marc.zyngier@xxxxxxx]
>Sent: Friday, December 18, 2015 6:31 PM

>> Note that I am working with ARC (seem alike) here and we do not define
>> CONFIG_HANDLE_DOMAIN_IRQ and do not implement set_handle_irq().
>>
>> So for ARC this reverse mapping is something we can leave without
>> (maybe because we are kind of a legacy domain).

>Yeah, I just located the crap: arch_do_IRQ() happily takes a hwirq (the vector number), and uses that as a Linux IRQ. This looks a lot like ARM pre-DT, about 10 years ago.

>Well, time to meet the 21st century. If you intend to use DT, please fix your arch port. Otherwise, just hardcode everything in your platform and don't pretend to support device tree.

Thank you very much.
I have the complete picture now.

Will discuss with ARC maintainer and see what best way to do this change.

-Noam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/