Re: [PATCH V5 1/2] watchdog: Use static struct class watchdog_class in stead of pointer

[Guenter Roeck]

On 12/18/2015 08:22 PM, Pratyush Anand wrote:
> On 17/12/2015:06:56:27 AM, Guenter Roeck wrote:
> > On 12/17/2015 04:23 AM, Pratyush Anand wrote:
> > > We need few sysfs attributes to know different status of a watchdog device.
> > > To do that, we need to associate .dev_groups with watchdog_class. So
> > > convert it from pointer to static.
> > > Putting this static struct in watchdog_dev.c, so that static device
> > > attributes defined in that file can be attached to it.
> > >
> > > Signed-off-by: Pratyush Anand <panand@xxxxxxxxxx>
> > > Suggested-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > > Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> >
> > As things evolve, I'd by now prefer to move the call to device_create()
> > into watchdog_dev.c, but that can wait for a follow-up patch if Wim
> > is ok with this series.
>
> Thanks for your quick review.
>
> OK. I will wait for Wim's comment and then may be I will send another
> version with your comment for patch 1/1 incorporated.

I reworked my patch to call device_create() from watchdog_dev.c on top of
your patches and on top of Wim's watchdog-next branch. Hopefully we can get
that into v4.5.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/