Re: pinctrl-adi2: Use a signed return type for adi_gpio_irq_startup()

From: Dan Carpenter
Date: Sat Dec 19 2015 - 15:45:25 EST


On Sat, Dec 19, 2015 at 09:40:27PM +0100, SF Markus Elfring wrote:
> > This introduces a compile warning.
>
> How do you think about to show the exact message you get?
>

I can't actually compile it myself.

>
> > These functions are supposed to return 1 if there is an IRQ pending.
> > Change the -EINVAL to 0.
>
> Is there any more source code clean-up needed around the comment "FIXME"
> in the affected function?

Delete the FIXME comment.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/