Re: [PATCH 05/10] perf tools: Add dynamic sort key for tracepoint events

[Jiri Olsa]

On Wed, Dec 16, 2015 at 12:35:38AM +0900, Namhyung Kim wrote:

SNIP

> +
> +	if (!len)
> +		len = hde_width(hde);
> +
> +	return len;
> +}
> +
> +static int __sort__hde_entry(struct perf_hpp_fmt *fmt, struct perf_hpp *hpp,
> +			     struct hist_entry *he)
> +{
> +	struct hpp_dynamic_entry *hde;
> +	size_t len = fmt->user_len;
> +	struct trace_seq seq;
> +	int ret;
> +
> +	hde = container_of(fmt, struct hpp_dynamic_entry, hpp);
> +
> +	if (!len)
> +		len = hde_width(hde);
> +
> +	if (hists_to_evsel(he->hists) != hde->evsel)
> +		return scnprintf(hpp->buf, hpp->size, "%*.*s", len, len, "N/A");

hum, how can this happen? ... "hists_to_evsel(he->hists) != hde->evsel"

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/