Re: [PATCH] mm: move lru_to_page to mm_inline.h

From: Vlastimil Babka
Date: Mon Dec 21 2015 - 05:15:00 EST


On 12/19/2015 10:08 AM, Geliang Tang wrote:
Move lru_to_page() from internal.h to mm_inline.h.

The file already contains functionality related to lru.

Signed-off-by: Geliang Tang <geliangtang@xxxxxxx>

Acked-by: Vlastimil Babka <vbabka@xxxxxxx>

---
include/linux/mm_inline.h | 2 ++
mm/internal.h | 2 --
mm/readahead.c | 1 +
3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h
index cf55945..712e8c3 100644
--- a/include/linux/mm_inline.h
+++ b/include/linux/mm_inline.h
@@ -100,4 +100,6 @@ static __always_inline enum lru_list page_lru(struct page *page)
return lru;
}

+#define lru_to_page(head) (list_entry((head)->prev, struct page, lru))
+
#endif
diff --git a/mm/internal.h b/mm/internal.h
index ca49922..5d8ec89 100644
--- a/mm/internal.h
+++ b/mm/internal.h
@@ -87,8 +87,6 @@ extern int isolate_lru_page(struct page *page);
extern void putback_lru_page(struct page *page);
extern bool zone_reclaimable(struct zone *zone);

-#define lru_to_page(_head) (list_entry((_head)->prev, struct page, lru))
-
/*
* in mm/rmap.c:
*/
diff --git a/mm/readahead.c b/mm/readahead.c
index 0aff760..20e58e8 100644
--- a/mm/readahead.c
+++ b/mm/readahead.c
@@ -17,6 +17,7 @@
#include <linux/pagemap.h>
#include <linux/syscalls.h>
#include <linux/file.h>
+#include <linux/mm_inline.h>

#include "internal.h"



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/