Re: [PATCH v3 38/77] ncr5380: Remove UNSAFE macro

[Hannes Reinecke]

On 12/22/2015 02:18 AM, Finn Thain wrote:
> Configuring core drivers using macros like this one prevents re-unifying
> the core driver forks, and prevents implementing the core driver as a
> library or a platform driver.
>
> The UNSAFE macro in particular is a poor workaround for the problem of
> interrupt latency. Releasing the locks complicates things because then we
> would have to handle the possibility of EH handler invocation during a
> PDMA transfer.
>
> The comments say that instead of using this macro, "you're going to be
> better off twiddling with transfersize". I agree. Remove this stuff.
>
> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>

Cheers,

Hannes
--
Dr. Hannes Reinecke		      zSeries & Storage
hare@xxxxxxx			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/