Re: [PATCH 5/6] ARM: dts: rockchip: add reboot mode node

[Andy Yan]

Hi,

On 2015å12æ22æ 11:04, Naoki FUKAUMI wrote:
> hi,
>
> On Mon, Dec 21, 2015 at 8:42 PM, Andy Yan<andy.yan@xxxxxxxxxxxxxx>  wrote:
> > Add reboot mode driver DT node for rk3xxx,rk3288 platform
> >
> > Signed-off-by: Andy Yan<andy.yan@xxxxxxxxxxxxxx>
> > ---
> >
> >   arch/arm/boot/dts/rk3288.dtsi                | 25 +++++++++++++++++++++++
> >   arch/arm/boot/dts/rk3xxx.dtsi                | 26 ++++++++++++++++++++++++
> >   include/dt-bindings/soc/rockchip_boot-mode.h | 30 ++++++++++++++++++++++++++++
> >   3 files changed, 81 insertions(+)
> >   create mode 100644 include/dt-bindings/soc/rockchip_boot-mode.h
> >
> > diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> > index 04ea209..937ba4c 100644
> > --- a/arch/arm/boot/dts/rk3288.dtsi
> > +++ b/arch/arm/boot/dts/rk3288.dtsi
> > @@ -170,6 +170,31 @@
> >                  };
> >          };
> >
> > +       reboot_mode {
> > +               compatible = "rockchip,reboot-mode";
> > +               rockchip,regmap = <&pmu>;
> > +               offset = <0x94>;
> > +               loader {
> > +                       linux,mode = "loader";
> > +                       linux,magic = <0x5242C301>;
> > +               };
> > +
> > +               maskrom {
> > +                       linux,mode = "maskrom";
> > +                       linux,magic = <0x5242C302>;
> > +               };
> > +
> > +               recovery {
> > +                       linux,mode = "recovery";
> > +                       linux,magic = <0x5242C303>;
> > +               };
> > +
> > +               fastboot {
> > +                       linux,mode = "fastboot";
> > +                       linux,magic = <0x5242C309>;
> > +               };
> > +       };
> > +
> (snip)
>
> I sometimes use 0xEF08A53C to load bootloader from SD card instead of
> on-board flash memory such as eMMC.
>   https://github.com/linux-rockchip/u-boot-rockchip/blob/u-boot-rk3288/common/cmd_rockusb.c#L893
>
> I don't know any detail about this function.
> (above code says "reboot to maskrom", but it should be wrong from my experience)
>
> do you know something about this function? can you handle this too?
>
> Regards,
 Have some discussion with the bootloader engineer, the correct magic  
number to
 reboot the system to maskrom mode is 0xEF08A53C. I will  fix it in 
next version.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/