Re: next-20151222 - compile failure in drivers/media/usb/uvc/uvc_driver.c

From: Javier Martinez Canillas
Date: Tue Dec 22 2015 - 07:40:52 EST


Hello Valdis,

On 12/22/2015 07:18 AM, Valdis Kletnieks wrote:
> next-20151222 fails to build for me:
>
> CC drivers/media/usb/uvc/uvc_driver.o
> drivers/media/usb/uvc/uvc_driver.c: In function 'uvc_probe':
> drivers/media/usb/uvc/uvc_driver.c:1941:32: error: 'struct uvc_device' has no member named 'mdev'
> if (media_device_register(&dev->mdev) < 0)
> ^
> scripts/Makefile.build:258: recipe for target 'drivers/media/usb/uvc/uvc_driver.o' failed
>
> 'git blame' points at that line being added in:
>
> commit 1590ad7b52714fddc958189103c95541b49b1dae
> Author: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
> Date: Fri Dec 11 20:57:08 2015 -0200
>
> [media] media-device: split media initialization and registration
>
> Not sure what went wrong here.
>

It was my forgetting to test with !CONFIG_MEDIA_CONTROLLER...

Anyways, I've already posted a fix for this:

https://lkml.org/lkml/2015/12/21/224

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/