Re: [RFC PATCH 2/5] crypto: sunxi-ss: fix min3() call to match types

From: Arnd Bergmann
Date: Tue Dec 22 2015 - 17:07:53 EST


On Tuesday 22 December 2015, Andre Przywara wrote:
> The min3() macro expects all arguments to be of the same type (or
> size at least). While two arguments are ints or u32s, one is size_t,
> which does not match on 64-bit architectures.
> Cast the size_t to u32 to make min3() happy. In this context here the
> length should never exceed 32 bits anyway.
>
> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>

Looks correct, but a bit ugly. Could we avoid the casts by using
temporary variables to keep the size_t based data?

Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/