Re: [PATCH v4] crypto: KEYS: convert public key and digsig asym to the akcipher api

From: Tadeusz Struk
Date: Wed Dec 23 2015 - 10:02:31 EST


On 12/23/2015 06:51 AM, Herbert Xu wrote:
>> > Changes in v4:
>> > - Flatten both patches into one to avoid bisect compilation problems.
> Why is this necessary?

Because the first patch modifies the struct public_key and removes the MPIs from it,
which the code modified in the second patch still uses. If bisect only takes the first
then the build will fail on the security/integrity/digsig_asymmetric.c as reported by
kbuild test robot:

>> security/integrity/digsig_asymmetric.c:95:5: error: 'struct public_key_signature' has no member named 'nr_mpi'
pks.nr_mpi = 1;

Thanks,
--
TS
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/