Re: [PATCH 0/5] watchdog: Do not use 'dev' from watchdog_device in watchdog drivers

[Damien Riegel]

On Wed, Dec 23, 2015 at 09:11:28PM -0800, Guenter Roeck wrote:
> The 'dev' variable in watchdog drivers has a different lifetime than the
> watchdog character device and should therefore not be used by watchdog
> drivers.
> 
> Some of the drivers use the variable to print kernel messages. Those are
> either dropped or converted to use pr_ functions. One driver sets the
> variable during initialization to the watchdog driver's parent device,
> which is wrong and also removed.

Hi Guenter,

For gpio_wdt and mena21_wdt, wdd->parent is set and could be used for
dev_* printings. Do you prefer to keep this variable only for watchdog
core internal usage? Otherwise, the serie looks good.

Thanks,
Damien
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/