Re: [PATCH] mm: fix noisy sparse warning in LIBCFS_ALLOC_PRE()

From: Al Viro
Date: Sun Dec 27 2015 - 00:42:10 EST


On Sat, Dec 26, 2015 at 09:12:42PM -0800, Joshua Clayton wrote:
> running sparse on drivers/staging/lustre results in dozens of warnings:
> include/linux/gfp.h:281:41: warning:
> odd constant _Bool cast (400000 becomes 1)
>
> Use "!!" to explicitly convert the result to bool range.

... and the cast to bool is left in order to...?

> - return (bool __force)(gfp_flags & __GFP_DIRECT_RECLAIM);
> + return (bool __force)!!(gfp_flags & __GFP_DIRECT_RECLAIM);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/