Re: [PATCH 0/2] Fixes for dell-wmi

From: Pali RohÃr
Date: Sun Dec 27 2015 - 08:08:41 EST


On Sunday 27 December 2015 13:59:57 Gabriele Mazzotta wrote:
> On 24/12/2015 22:18, Pali RohÃr wrote:
> > This patch series adds check if Dell WMI descriptor structure is
> > valid and fixes processing WMI events on devices with WMI
> > interface version 0.
> >
> > After testing, second patch is good candidate for backporting into
> > stable kernels, but problem is that it cannot be used without
> > first patch. So I let decision to other people.
> >
> > Gabriele and MichaÅ, this patch series should fix processing events
> > on yours Dell laptops (you have in DSDT defined version 0). Can
> > you test it?
>
> Hi,
>
> I tested the patches and all the function keys work, but I can see
> that there are some differences in the dmesg.
>
> Here a before and after comparison.
>
> The radio button seems to generate longer messages when compared to
> the others.

Hi! Thanks for testing. Can you please recompile driver with line
#define DEBUG at beginning of dell-wmi.c file and send dmesg output
again? I want to see processing buffer debug lines in dmesg. Here we
should see that after this patch series garbage will not be parsed.

--
Pali RohÃr
pali.rohar@xxxxxxxxx

Attachment: signature.asc
Description: This is a digitally signed message part.