Re: [PATCH] thinkpad_acpi: Add support for keyboard backlight

[Henrique de Moraes Holschuh]

On Thu, 24 Dec 2015, Pali Rohár wrote:
> This patch adds support for controlling keyboard backlight via standard
> linux led class interface (::kbd_backlight). It uses ACPI HKEY device with
> MLCG and MLCS methods.
> 
> Signed-off-by: Pali Rohár <pali.rohar@xxxxxxxxx>
> Tested-by: Fabio D'Urso <fabiodurso@xxxxxxxxxx>

It looks good at a first glance.  But at init you might need to take steps
so that the current state is not changed.  Did you test this?

Also, is it working properly across suspend+resume?

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/