Re: [PATCH] MAINTAINERS: Add myself as a reviewer for the bq27xxx driver.

[Pali RohÃr]

On Thursday 31 December 2015 22:06:38 Sebastian Reichel wrote:
> Hi,
> 
> On Thu, Dec 31, 2015 at 07:40:04PM +0100, Pali RohÃr wrote:
> > On Wednesday 30 December 2015 19:35:41 Andrew F. Davis wrote:
> > > Signed-off-by: Andrew F. Davis <afd@xxxxxx>
> > > ---
> > > 
> > >  MAINTAINERS | 10 ++++++++--
> > >  1 file changed, 8 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 44666b1..046d001 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -7605,10 +7605,8 @@ NOKIA N900 POWER SUPPLY DRIVERS
> > > 
> > >  M:	Pali RohÃr <pali.rohar@xxxxxxxxx>
> > >  S:	Maintained
> > >  F:	include/linux/power/bq2415x_charger.h
> > > 
> > > -F:	include/linux/power/bq27xxx_battery.h
> > > 
> > >  F:	include/linux/power/isp1704_charger.h
> > >  F:	drivers/power/bq2415x_charger.c
> > > 
> > > -F:	drivers/power/bq27xxx_battery.c
> > > 
> > >  F:	drivers/power/isp1704_charger.c
> > >  F:	drivers/power/rx51_battery.c
> > 
> > I think it is not needed to remove files from this section as here
> > are all power supply files for Nokia N900.
> > 
> > > @@ -10710,6 +10708,14 @@ L:	linux-omap@xxxxxxxxxxxxxxx
> > > 
> > >  S:	Maintained
> > >  F:	drivers/thermal/ti-soc-thermal/
> > > 
> > > +TI BQ27XXX POWER SUPPLY DRIVER
> > > +M:	Pali RohÃr <pali.rohar@xxxxxxxxx>
> > > +R:	Andrew F. Davis <afd@xxxxxx>
> > > +S:	Maintained
> > > +F:	include/linux/power/bq27xxx_battery.h
> > > +F:	drivers/power/bq27xxx_battery.c
> > > +F:	drivers/power/bq27xxx_battery_i2c.c
> 
> I think it would make sense to have it like this:
> 
> NOKIA N900 POWER SUPPLY DRIVERS
> +R:	Pali RohÃr <pali.rohar@xxxxxxxxx>
> -M:	Pali RohÃr <pali.rohar@xxxxxxxxx>
> -S:	Maintained
> F:	include/linux/power/bq2415x_charger.h
> F:	include/linux/power/bq27xxx_battery.h
> F:	include/linux/power/isp1704_charger.h
> F:	drivers/power/bq2415x_charger.c
> F:	drivers/power/bq27xxx_battery.c
> F:	drivers/power/isp1704_charger.c
> F:	drivers/power/rx51_battery.c
> 
> +TI BQ27XXX POWER SUPPLY DRIVER
> +R:	Andrew F. Davis <afd@xxxxxx>
> +F:	include/linux/power/bq27xxx_battery.h
> +F:	drivers/power/bq27xxx_battery.c
> +F:	drivers/power/bq27xxx_battery_i2c.c
> +
> POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS
> M:	Sebastian Reichel <sre@xxxxxxxxxx>
> M:	Dmitry Eremin-Solenikov <dbaryshkov@xxxxxxxxx>
> M:	David Woodhouse <dwmw2@xxxxxxxxxxxxx>
> L:	linux-pm@xxxxxxxxxxxxxxx
> T:	git git://git.infradead.org/battery-2.6.git
> S:	Maintained
> F:	include/linux/power_supply.h
> F:	drivers/power/
> X:	drivers/power/avs/
> 
> This would result in the following get_maintainer.pl output
> for the bq27xxx driver.
> 
> sre@earth ~/src/linux [n950] % ./scripts/get_maintainer.pl -f
> drivers/power/bq27xxx_battery.c "Andrew F. Davis" <afd@xxxxxx>
> (reviewer:TI BQ27XXX POWER SUPPLY DRIVER) "Pali RohÃr"
> <pali.rohar@xxxxxxxxx> (reviewer:NOKIA N900 POWER SUPPLY DRIVERS)
> Sebastian Reichel <sre@xxxxxxxxxx> (maintainer:POWER SUPPLY
> CLASS/SUBSYSTEM and DRIVERS) Dmitry Eremin-Solenikov
> <dbaryshkov@xxxxxxxxx> (maintainer:POWER SUPPLY CLASS/SUBSYSTEM and
> DRIVERS) David Woodhouse <dwmw2@xxxxxxxxxxxxx> (maintainer:POWER
> SUPPLY CLASS/SUBSYSTEM and DRIVERS) linux-pm@xxxxxxxxxxxxxxx (open
> list:POWER SUPPLY CLASS/SUBSYSTEM and DRIVERS)
> linux-kernel@xxxxxxxxxxxxxxx (open list)
> 
> Pali, what do you think about the reviewer/maintainer change?
> I think it makes it more clear, that the patches are queued in
> the battery tree. If you think its a downgrade I don't mind not
> changing it, though.
> 
> -- Sebastian

Change is OK for me.

-- 
Pali RohÃr
pali.rohar@xxxxxxxxx

Attachment: signature.asc
Description: This is a digitally signed message part.