Re: [PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()
From: SF Markus Elfring
Date: Sat Jan 02 2016 - 03:11:11 EST
>> Move the jump label directly before the desired log statement
>> so that the variable "err" will not be checked once more
>> after it was determined that a function call failed.
>> Use the identifier "report_failure" instead of the label "err".
>
> Why?
I suggest to reconsider the places with which such a jump label
is connected.
> The code was smart enough
Which action should really be performed after a failure was detected
and handled a bit already?
* Another condition check
* Just additional error logging
> and you're making it uglier that it needs to be.
I assume that a software development taste can evolve, can't it?
Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/