Re: [PATCH 2/2] net-qmi_wwan: Delete an unnecessary variable initialisation in qmi_wwan_register_subdriver()

From: David Miller
Date: Sat Jan 02 2016 - 20:46:35 EST


From: Bjørn Mork <bjorn@xxxxxxx>
Date: Sat, 02 Jan 2016 22:30:48 +0100

> SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx> writes:
>
>> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
>> Date: Fri, 1 Jan 2016 17:35:03 +0100
>>
>> Omit explicit initialisation at the beginning for one local variable
>> that is redefined before its first use.
>
>
> This patch is unnecessary. The variable initialisation is redundant.
> See the difference? Sending an unnecessary patch causes unnecessary
> load on reviewers and maintainers. Keeping redundant code has no
> measurable cost, and can save the same maintainers a lot of trouble
> later.

+1

I'm getting really tired of these changes. And a lot of them are
coming in right now...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/