Re: [PATCH v6 1/4] x86: Clean up extable entry format (and free up a bit)

[Ingo Molnar]

* Tony Luck <tony.luck@xxxxxxxxx> wrote:

> On Wed, Dec 30, 2015 at 9:59 AM, Andy Lutomirski <luto@xxxxxxxxxxxxxx> wrote:
> > This adds two bits of fixup class information to a fixup entry,
> > generalizing the uaccess_err hack currently in place.
> >
> > Forward-ported-from-3.9-by: Tony Luck <tony.luck@xxxxxxxxx>
> > Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
> 
> Crivens!  I messed up when "git cherrypick"ing this and "git
> format-patch"ing it.
> 
> I didn't mean to forge Andy's From line when sending this out (just to have a
> From: line to give him credit.for the patch).
> 
> Big OOPs ... this is "From:" me ... not Andy!

But in any case it's missing your SOB line.

If Andy is still the primary author (much of his original patch survived, you 
resolved conflicts or minor changes) then you can send this as:

 From: Tony Luck <tony.luck@xxxxxxxxx>
 Subject: [PATCH v6 1/4] x86: Clean up extable entry format (and free up a bit)

 From: Andy Lutomirski <luto@xxxxxxxxxxxxxx>

 ... changelog ...

 Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
 [ Forward ported from a v3.9 version. ]
 Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx

This carries all the information, has a proper SOB chain, and preserves 
authorship. Also, it's clear from the tags that you made material changes, so any 
resulting breakage is yours (and mine), not Andy's! ;-)

If the changes to the patch are major, so that your new work is larger than Andy's 
original work, you can still credit him via a non-standard tag, like:

 From: Tony Luck <tony.luck@xxxxxxxxx>
 Subject: [PATCH v6 1/4] x86: Clean up extable entry format (and free up a bit)

 This patch is based on Andy Lutomirski's patch sent against v3.9:

 ... changelog ...

 Originally-from: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
 Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/