Re: [PATCH] Staging: speakup: Fix getting port information

From: Dan Carpenter
Date: Mon Jan 04 2016 - 07:27:03 EST


On Mon, Jan 04, 2016 at 03:22:49PM +0300, Dan Carpenter wrote:
> On Sun, Jan 03, 2016 at 01:56:20AM +0100, Samuel Thibault wrote:
> > covici@xxxxxxxxxxxxxx, on Sat 02 Jan 2016 19:10:36 -0500, wrote:
> > > I had a patch which also worked, but yours may be better -- I enclose it
> > > here for your information.
> >
> > Well, it's not up to serialio.h to include things for serialio.c. That
> > however makes me realize that the culprit is actually
> > f79b0d9 (which actually doesn't make much sense since linux/serial.h is
> > getting included a couple of lines above...).
>

Btw, the patch title of that patch f79b0d9c223a ('staging: speakup:
Fixed warning <linux/serial.h> instead of <asm/serial.h>') describes
exactly everything about the patch. So including the title really does
help save time for everyone.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/