Re: [PATCH 1/6] 8250/Kconfig: add config option CONFIG_SERIAL_8250_AMD

[Borislav Petkov]

On Mon, Jan 04, 2016 at 01:31:36PM +0800, Wang Hongcheng wrote:
> Add config option  CONFIG_SERIAL_8250_AMD in use of AMD carrizo.
> Because carrizo's UART DMA device is an amba device, it selects
> ARM_AMBA option. Anything uses amba devices must select ARM_AMBA.
> 
> Signed-off-by: Wang Hongcheng <annie.wang@xxxxxxx>
> ---
>  drivers/tty/serial/8250/Kconfig | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
> index 6412f14..c9ebc31 100644
> --- a/drivers/tty/serial/8250/Kconfig
> +++ b/drivers/tty/serial/8250/Kconfig
> @@ -378,3 +378,11 @@ config SERIAL_8250_MID
>  	  Selecting this option will enable handling of the extra features
>  	  present on the UART found on Intel Medfield SOC and various other
>  	  Intel platforms.
> +
> +config SERIAL_8250_AMD
> +	bool "AMD carrizo serial port support"
> +	depends on SERIAL_8250
> +	select ARM_AMBA
> +	help
> +	  If you have a Family 15h, models 0x60-0x6F based board and want to
> +	  use the serial port, say Y to this option. If unsure, say N.

Hmm, so you're adding this config option here only to have
acpi_apd_setup_quirks() defined in an already AMD-specific compilation
unit drivers/acpi/acpi_apd.c.

So why not make drivers/acpi/acpi_apd.c depend on CPU_SUP_AMD
and this way it is automatically enabled on AMD and then check
family/model/stepping when assigning that

+       .post_setup = acpi_apd_setup_quirks,

thing?

You need it only on F15h, models 0x60.. only so you don't really need
the config option when you can find out on what hardware you're running
without the user having to configure the kernel.

Hmmm?

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/