Re: [PATCH v4] i2c: designware: Do not require clock when SSCN and FFCN are provided

From: Wolfram Sang
Date: Mon Jan 04 2016 - 11:15:52 EST


On Mon, Jan 04, 2016 at 09:17:35AM -0600, Suravee Suthikulpanit wrote:
> The current driver uses input clock source frequency to calculate
> values for [SS|FS]_[HC|LC] registers. However, when booting ACPI, we do not
> currently have a good way to provide the frequency information.
> Instead, we can leverage the SSCN and FFCN ACPI methods, which can be used
> to directly provide these values. So, the clock information should
> no longer be required during probing.
>
> However, since clk can be invalid, additional checks must be done where
> we are making use of it.
>
> Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@xxxxxxx>
> Tested-by: Loc Ho <lho@xxxxxxx>
> ---
>
> Note: This has been tested on AMD Seattle RevB for both DT and ACPI.
>
> Changes from V3 (https://lkml.org/lkml/2015/12/22/596):
> * Add i2c_dw_plat_prepare_clk() per Andy's suggestion
> * Add tested-by Loc Ho.

The changes from V3 are big enough that I'd appreciate a new Tested-by
tag.

Attachment: signature.asc
Description: Digital signature