Re: [PATCH] OrangeFS: constify export_operations structures

From: Mike Marshall
Date: Mon Jan 04 2016 - 11:18:08 EST


Hi Julia... thanks for the patch... I've applied it to my github repo,
so it will be in the next push to kernel.org.

Orangefs is still out-of-tree (only temporarily I hope ;-) so I guess I
don't belong in the MAINTAINERS file yet...

-Mike

On Fri, Jan 1, 2016 at 4:01 AM, Julia Lawall <Julia.Lawall@xxxxxxx> wrote:
> This export_operations structure is never modified, so declare it as const.
> Most other structures of this type are already const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>
>
> ---
>
> Mike, I saw your name on all of the patches for this driver, but you aren't
> in the MAINTAINERS file. If you are the maintainer of this file, maybe you
> should add yourself there.
>
> fs/orangefs/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/orangefs/super.c b/fs/orangefs/super.c
> index 52bc522..bee67b3 100644
> --- a/fs/orangefs/super.c
> +++ b/fs/orangefs/super.c
> @@ -342,7 +342,7 @@ out:
> return type;
> }
>
> -static struct export_operations orangefs_export_ops = {
> +static const struct export_operations orangefs_export_ops = {
> .encode_fh = orangefs_encode_fh,
> .fh_to_dentry = orangefs_fh_to_dentry,
> };
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/